Repository navigation
docs: stop telling readers to source a task bundle that no longer exists - #561
Merged
Merged
Conversation
`files/ghost_peak_experiment.py` and `files/pca_rotation_experiment.py` told readers to `source ~/Code/PyAutoLabs-wt/rectangular-adapt-cdf/activate.sh` — an absolute path to a task bundle that was removed long ago, and which contradicted the line beneath it, where `python PyAutoArray/files/...` already assumed cwd was the workspace root. Both now say to run from the workspace root (or a task-bundle root) with its own ./activate.sh sourced. Prose only; no code depends on these lines. 1584 passed. Note: both scripts import autoarray.inversion.mesh.interpolator.rectangular_spline, which no longer exists — they cannot run at all. That is pre-existing, out of scope for a docstring fix, and filed as its own decision (keep and repair, or retire) in PyAutoMind draft/maintenance/autoarray/files_experiment_scripts_import_a_removed_module.md. Part of PyAutoBrain#393 (phase 2). No directory layout changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0161NLKVzbBMzhaBfjpGogor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of PyAutoLabs/PyAutoBrain#393 (phase 2). Changes no directory layout. Docstrings only. Companions: PyAutoLabs/PyAutoMind#415, PyAutoReduce (same branch name).
The change
files/ghost_peak_experiment.py:39andfiles/pca_rotation_experiment.py:28told readers to:— an absolute path to a task bundle removed long ago, which also contradicted the line beneath it, where
python PyAutoArray/files/...already assumed cwd was the workspace root. Both now say to run from the workspace root (or a task-bundle root) with its own./activate.shsourced.Prose only; no code depends on these lines. 1584 passed.
Found while doing it — filed, not fixed here
Both scripts import
autoarray.inversion.mesh.interpolator.rectangular_spline, which no longer exists (the live modules arerectangular.py,rectangular_uniform.py,delaunay.py, …), so neither can run at all. Independently confirmed by the workspace's PyAuto API gate: "STALE … not in installed stack; closest live names: rectangular".They were committed with the
rectangular-adapt-cdfspike and the module has since been renamed or removed — consistent with their docstrings still naming that long-gone bundle. Nothing references either file except each other andfiles/ghost_peak_findings.md.That is pre-existing and out of scope for a docstring fix, and it is a decision rather than a bug: keep and repair, or retire. Filed as
PyAutoMind draft/maintenance/autoarray/files_experiment_scripts_import_a_removed_module.mdrather than guessing an import that merely makes them parse.🤖 Generated with Claude Code
https://claude.ai/code/session_0161NLKVzbBMzhaBfjpGogor